Hi, David, Andrew et al. 2011/2/21 David Fries <david@xxxxxxxxx>: > bt_sk(sk)->parent can be NULL in l2cap_conn_start in state BT_CONNECT2 > at least when a headset device pairs and the play button was pressed > right before pairing. > > Signed-off-by: David Fries <david@xxxxxxxxx> > --- > I removed the printk, can this be merged to the bluetooth next tree? > > On Mon, Feb 14, 2011 at 03:40:46PM -0600, Andrei Warkentin wrote: >> FWIW still need it in 2.6.36. > > Andrei, I'm curious, what's your hardware hardware and bluetooth > device that's trigginer the crash? I once submitted an issue observed with Android+Motorola S305 stereo headset. It's still open in launchpad: https://bugs.launchpad.net/ubuntu/+source/bluez/+bug/513642. Hope this helps. Thanks. > >> On Mon, Feb 14, 2011 at 8:56 AM, Gustavo F. Padovan >> <padovan@xxxxxxxxxxxxxx> wrote: >> > Hi David, >> > >> > * David Fries <david@xxxxxxxxx> [2011-02-10 21:53:09 -0600]: >> > >> >> Here's a patch to avoid a very repeatable crash in the N900. If I >> >> take a Motorola S305 bluetooth headset that was previously paried with >> >> the N900, turn it on, and press the play button before the headphones >> >> automatically pair with the cell phone, the N900 will crash (and >> >> reboot) in pairing. If I wait until after they have paired there >> >> isn't any problem. The patch is against the kernel-power >> >> 2.6.28-maemo46 by Thomas Tanner, the stock Nokia PR1.2 oops looked >> >> the same, I just haven't gone back to that kernel. >> > >> > This is a very old kernel. You need to check this issue against >> > bluetooth-next-2.6. > > net/bluetooth/l2cap.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c > index ed83c1f..a7aa4d9 100644 > --- a/net/bluetooth/l2cap.c > +++ b/net/bluetooth/l2cap.c > @@ -408,7 +408,8 @@ static void l2cap_conn_start(struct l2cap_conn *conn) > struct sock *parent = bt_sk(sk)->parent; > rsp.result = cpu_to_le16(L2CAP_CR_PEND); > rsp.status = cpu_to_le16(L2CAP_CS_AUTHOR_PEND); > - parent->sk_data_ready(parent, 0); > + if(parent) > + parent->sk_data_ready(parent,0); > > } else { > sk->sk_state = BT_CONFIG; > -- > 1.7.2.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
