On 16/02/2024 21:32, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > Add device-tree bindings for the ATH12K module found in the WCN7850 > package. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > --- > .../net/wireless/qcom,ath12k-pci.yaml | 103 ++++++++++++++++++ > 1 file changed, 103 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml > new file mode 100644 > index 000000000000..063c576b99a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml This means there can be ath12k over AHB or some other bus, which would be quite different and not fit together in one schema file. It's that the case? > @@ -0,0 +1,103 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2024 Linaro Limited > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies ath12k wireless devices (PCIe) > + > +maintainers: > + - Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > + > +description: | Do not need '|' unless you need to preserve formatting. > + Qualcomm Technologies IEEE 802.11ax PCIe devices > + > +properties: > + compatible: > + enum: > + - pci17cb,1107 # WCN7850 > + > + reg: > + maxItems: 1 > + > + enable-gpios: > + maxItems: 1 > + description: GPIO line enabling the WLAN module > + > + vdd-supply: > + description: VDD supply regulator handle > + > + vddio-supply: > + description: VDD_IO supply regulator handle > + > + vddio1p2-supply: > + description: VDD_IO_1P2 supply regulator handle > + > + vddaon-supply: > + description: VDD_AON supply regulator handle > + > + vdddig-supply: > + description: VDD_DIG supply regulator handle > + > + vddrfa1p2-supply: > + description: VDD_RFA_1P2 supply regulator handle > + > + vddrfa1p8-supply: > + description: VDD_PCIE_1P8 supply regulator handle > + > + clocks: > + maxItems: 1 > + description: > + Reference clock phandle These three could be just: items: - description: Reference clock (phandle is redundant in this context) Best regards, Krzysztof
