Re: [RFC PATCH v2 1/3] gnss: Add AI2 protocol used by some TI combo chips.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Andreas,


Thank you for your patch. I think Linux Bluetooth patches need to be have Bluetooth as the prefix for the commit message summary/title. Also, it’d be great if you removed the dot/period at the end of the commit message summary/title.

Am 28.01.24 um 18:33 schrieb Andreas Kemnade:
Texas Instruments uses something called Air Independent Interface (AI2) for
their WLAN/BT/GPS combo chips.
No public documentation is available, but allow that protocol to be
specified.

I’d add a blank line between paragraphs.

Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
---
  drivers/gnss/core.c  | 1 +
  include/linux/gnss.h | 1 +
  2 files changed, 2 insertions(+)

diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c
index 48f2ee0f78c4d..cac9f45aec4b2 100644
--- a/drivers/gnss/core.c
+++ b/drivers/gnss/core.c
@@ -335,6 +335,7 @@ static const char * const gnss_type_names[GNSS_TYPE_COUNT] = {
  	[GNSS_TYPE_SIRF]	= "SiRF",
  	[GNSS_TYPE_UBX]		= "UBX",
  	[GNSS_TYPE_MTK]		= "MTK",
+	[GNSS_TYPE_AI2]		= "AI2",
  };
static const char *gnss_type_name(const struct gnss_device *gdev)
diff --git a/include/linux/gnss.h b/include/linux/gnss.h
index 36968a0f33e8d..16b565dab83ea 100644
--- a/include/linux/gnss.h
+++ b/include/linux/gnss.h
@@ -23,6 +23,7 @@ enum gnss_type {
  	GNSS_TYPE_SIRF,
  	GNSS_TYPE_UBX,
  	GNSS_TYPE_MTK,
+	GNSS_TYPE_AI2,
GNSS_TYPE_COUNT
  };

Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>


Kind regards,

Paul




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux