Hi, On Thu, 25 Jan 2024 at 01:07, Emil Velikov via B4 Relay <devnull+emil.l.velikov.gmail.com@xxxxxxxxxx> wrote: > > Hello everyone, > > Here's v3 fixing a small bug with the previous patches, which was > tripping the CI. > > Link to the previous revision can be found below. Just a comment that external plugins support was added to avoid udev dependency (from sixaxis) in bluetoothd. (not that I have strong opinion on this, just a note, I don't remember exactly why it was done, maybe Marcel recalls?) > > Thanks > Emil > > - Link to v2: https://lore.kernel.org/r/20240124-rm-ext-plugins-v2-0-5244906f05ff@xxxxxxxxx > > --- > Emil Velikov (8): > configure, README: introduce --enable-external-plugins > obexd: factor out external plugin support > bluetoothd: remove external-dummy plugin > bluetoothd: convert external sixaxis plugin to builtin > bluetoothd: factor out external plugin support > bluetoothd: don't export internal API > bluetoothd: change plugin loading alike obexd > android: export only (android) entrypoint from the modules > > Makefile.am | 17 ++---- > Makefile.obexd | 2 + > Makefile.plugins | 8 +-- > README | 13 +++++ > android/Makefile.am | 3 + > android/hal-audio.c | 1 + > android/hal-bluetooth.c | 1 + > android/hal-sco.c | 1 + > configure.ac | 10 ++++ > obexd/src/obexd.h | 2 +- > obexd/src/plugin.c | 93 +++++++++++++++++++++---------- > obexd/src/plugin.h | 4 ++ > plugins/external-dummy.c | 28 ---------- > src/btd.h | 2 +- > src/plugin.c | 140 +++++++++++++++++++++++++++++------------------ > src/plugin.h | 16 ++++++ > 16 files changed, 209 insertions(+), 132 deletions(-) > --- > base-commit: a9d1f6f6a625607de6c3f5b7a40a3aac5f36c02b > change-id: 20240116-rm-ext-plugins-ba0b852a492b > > Best regards, > -- > Emil Velikov <emil.l.velikov@xxxxxxxxx> > > -- pozdrawiam Szymon K. Janc