Hi Emil, On Tue, Jan 16, 2024 at 9:19 AM Emil Velikov via B4 Relay <devnull+emil.l.velikov.gmail.com@xxxxxxxxxx> wrote: > > Greetings one and all, > > In this series, we prune support for external plugins and cleanup the > associated code. The inspiration here is multiple-fold: > - the plugins are under linked - generally a bad idea > - the plugins use undefined, unscoped, unversioned internal API > - the main daemons expose their internal API increasing their size Im not so sure I want to remove the external plugins support completely, but I do understand that normally distros don't really want to have it enabled in production due to the reasons mentioned above, but I think we could find a middle ground here by disabling it by default but still let systems to re-enable it if they have some custom plugin that they may still want to use as external plugin. > So this series: > - bluetoothd: removes the "dummy" external plugin > - bluetoothd: converts the sixaxis plugin to builtin > - bluetoothd, obexd: removes support for external plugins > - bluetoothd, obexd: cleans the exported symbols by the daemons > - android: (bonus) export only the required HMI plugin entrypoint > > Please note: > - expect minor conflicts wrt my earlier patches - happy to respin > - there _might_ be third-party external plugins, that my distro search > have missed > > This concludes the paper cut patches. Expect some more around config > file handling in the upcoming days :-) > > Thanks > Emil > > --- > Emil Velikov (8): > obexd: remove support for external plugins > build: don't export internal obexd API > plugins: remove external-dummy > plugins: convert external sixaxis plugin to builtin > bluetoothd: remove support for external plugins > bluetoothd: remove debug support for external plugins > bluetoothd: don't export internal API > android: export only (android) entrypoint from the modules > > Makefile.am | 21 +------------- > Makefile.obexd | 8 ++---- > Makefile.plugins | 8 ++---- > android/Makefile.am | 3 ++ > android/hal-audio.c | 1 + > android/hal-bluetooth.c | 1 + > android/hal-sco.c | 1 + > obexd/src/obexd.h | 2 +- > obexd/src/plugin.c | 73 ++++------------------------------------------- > obexd/src/plugin.h | 9 ------ > plugins/external-dummy.c | 28 ------------------ > src/bluetooth.ver | 20 ------------- > src/btd.h | 2 +- > src/log.c | 10 ++----- > src/log.h | 3 +- > src/plugin.c | 74 ++++-------------------------------------------- > src/plugin.h | 16 ----------- > 17 files changed, 30 insertions(+), 250 deletions(-) > --- > base-commit: 770ad5614e7e8074133e6f563495ce4822f63fe4 > change-id: 20240116-rm-ext-plugins-ba0b852a492b > > Best regards, > -- > Emil Velikov <emil.l.velikov@xxxxxxxxx> > > -- Luiz Augusto von Dentz
