Re: [PATCH v1] Bluetooth: hci_sync: Fix accept_list when attempting to suspend

[Paul Menzel <pmenzel@xxxxxxxxxxxxx>]

Dear Luiz,


Thank you for your patch.

Am 05.01.24 um 17:10 schrieb Luiz Augusto von Dentz:
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> During suspend, only wakeable devices can be in acceptlist, so if the
> device was previously added it needs to be removed otherwise the can end

… the *device* can?

> up waking up the system prematurely.
>
> Fixes: 3b42055388c3 ("Bluetooth: hci_sync: Fix attempting to suspend with unfiltered passive scan")
> Signed-off-by: Clancy Shang <clancy.shang@xxxxxxxxxxx>
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
> ---
>   net/bluetooth/hci_sync.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
> index b3141e3f9cf6..5716345a26df 100644
> --- a/net/bluetooth/hci_sync.c
> +++ b/net/bluetooth/hci_sync.c
> @@ -2206,8 +2206,11 @@ static int hci_le_add_accept_list_sync(struct hci_dev *hdev,
>   
>   	/* During suspend, only wakeable devices can be in acceptlist */
>   	if (hdev->suspended &&
> -	    !(params->flags & HCI_CONN_FLAG_REMOTE_WAKEUP))
> +	    !(params->flags & HCI_CONN_FLAG_REMOTE_WAKEUP)) {
> +		hci_le_del_accept_list_sync(hdev, &params->addr,
> +					    params->addr_type);
>   		return 0;
> +	}
>   
>   	/* Select filter policy to accept all advertising */
>   	if (*num_entries >= hdev->le_accept_list_size)

Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>


Kind regards,

Paul