On Fri, Dec 15, 2023 at 02:36:31PM +0100, Johan Hovold wrote: > On Thu, Dec 14, 2023 at 06:01:46PM +0100, Francesco Dolcini wrote: > > From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > > > > receive_buf() is called from ttyport_receive_buf() that expects values > > ">= 0" from serdev_controller_receive_buf(), change its return type from > > ssize_t to size_t. > > > > Suggested-by: Jiri Slaby <jirislaby@xxxxxxxxxx> > > Link: https://lore.kernel.org/all/087be419-ec6b-47ad-851a-5e1e3ea5cfcc@xxxxxxxxxx/ > > Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > > --- > > drivers/gnss/core.c | 6 +++--- > > drivers/gnss/serial.c | 4 ++-- > > drivers/gnss/sirf.c | 6 +++--- > > > diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c > > index 48f2ee0f78c4..9b8a0605ec76 100644 > > --- a/drivers/gnss/core.c > > +++ b/drivers/gnss/core.c > > @@ -317,10 +317,10 @@ EXPORT_SYMBOL_GPL(gnss_deregister_device); > > * > > * Must not be called for a closed device. > > */ > > -int gnss_insert_raw(struct gnss_device *gdev, const unsigned char *buf, > > - size_t count) > > +size_t gnss_insert_raw(struct gnss_device *gdev, const unsigned char *buf, > > + size_t count) > > { > > - int ret; > > + size_t ret; > > > > ret = kfifo_in(&gdev->read_fifo, buf, count); > > > > Why are you changing this function? This is part of the GNSS interface > and has nothing to do with the rest of this patch. > > Greg, please drop this one again until this has been resolved. Now dropped, thanks.
