Hi Luiz, > -----Original Message----- > From: Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> > Sent: Wednesday, December 13, 2023 6:08 PM > To: Iulia Tanasescu <iulia.tanasescu@xxxxxxx> > Cc: Claudia Cristina Draghicescu <claudia.rosu@xxxxxxx>; linux- > bluetooth@xxxxxxxxxxxxxxx; Silviu Florian Barbulescu > <silviu.barbulescu@xxxxxxx> > Subject: Re: [BlueZ,v4,1/6] bap: Allow setup of multiple stream per > endpoint > > Hi Iulia, > > On Wed, Dec 13, 2023 at 10:56 AM Iulia Tanasescu > <iulia.tanasescu@xxxxxxx> wrote: > > > > Hi Luiz, > > > > > -----Original Message----- > > > From: Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> > > > Sent: Tuesday, December 12, 2023 7:54 PM > > > To: linux-bluetooth@xxxxxxxxxxxxxxx > > > Cc: Iulia Tanasescu <iulia.tanasescu@xxxxxxx>; Silviu Florian > Barbulescu > > > <silviu.barbulescu@xxxxxxx>; Claudia Cristina Draghicescu > > > <claudia.rosu@xxxxxxx> > > > Subject: Re: [BlueZ,v4,1/6] bap: Allow setup of multiple stream per > > > endpoint > > > > > > Hi, > > > > > > On Mon, Dec 11, 2023 at 6:31 PM <bluez.test.bot@xxxxxxxxx> wrote: > > > > > > > > This is automated email and please do not reply to this email! > > > > > > > > Dear submitter, > > > > > > > > Thank you for submitting the patches to the linux bluetooth mailing > list. > > > > This is a CI test results with your patch series: > > > > PW > > > > > Link:https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2 > > > > > > > > Fpatchwork.kernel.org%2Fproject%2Fbluetooth%2Flist%2F%3Fseries%3D808 > > > 93 > > > > > > > > 8&data=05%7C02%7Ciulia.tanasescu%40nxp.com%7C75f2033d3e9447dbe67 > > > d08dbf > > > > > > > > b3b5e2e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6383800 > > > 0462083582 > > > > > > > > 0%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi > L > > > CJBTiI6 > > > > > > > > Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=aKuHEA2BNmk3B% > > > 2BztdPJ2Mhl > > > > X1443Ki34d5537bCZuhE%3D&reserved=0 > > > > > > Could one of you guys please verify that this set doesn't break anything > > > related to broadcast. > > > > > > > I tested this patch series for broadcast and I found two issues: > > > > First, in bap_find_setup_by_stream, for the > BT_BAP_STREAM_TYPE_BCAST > > case, the function returns a pointer to an endpoint, although it's > > expected to return a pointer to the setup matching the stream. > > So it should be something similar to the unicast case: > > > > ep = queue_find(data->bcast, match_ep_stream, stream); > > if (ep) > > return queue_find(ep->setups, match_setup_stream, > > stream); > > Ok, I will fix that. > > > Second, in set_configuration, after allocating a setup using > > setup_new, you should also allocate setup->base: > > > > setup->base = new0(struct iovec, 1). > > Doesn't the base use util_iov_dup? Perhaps we need an update to code > to start using that. Our patch for multiple bis support will include updates regarding base processing, so this will be updated soon. > > > Otherwise, the configuration will not be parsed correctly for > > broadcast. > > > > We have also prepared a patch series for broadcast multiple BISes > > support, but we will have to update our implementation based on > > these patches. > > While at it, perhaps it would be great to create a sample script to > test broadcast with bluetoothctl. > > > > > ---Test result--- > > > > > > > > Test Summary: > > > > CheckPatch PASS 2.70 seconds > > > > GitLint FAIL 1.73 seconds > > > > BuildEll PASS 24.71 seconds > > > > BluezMake PASS 780.94 seconds > > > > MakeCheck PASS 12.60 seconds > > > > MakeDistcheck PASS 164.82 seconds > > > > CheckValgrind PASS 225.11 seconds > > > > CheckSmatch PASS 330.30 seconds > > > > bluezmakeextell PASS 103.81 seconds > > > > IncrementalBuild PASS 4181.08 seconds > > > > ScanBuild WARNING 990.81 seconds > > > > > > > > Details > > > > ############################## > > > > Test: GitLint - FAIL > > > > Desc: Run gitlint > > > > Output: > > > > [BlueZ,v4,2/6] shared/bap: Make bt_bap_select match the channel > map > > > > > > > > WARNING: I3 - ignore-body-lines: gitlint will be switching from using > Python > > > regex 'match' (match beginning) to 'search' (match anywhere) semantics. > > > Please review your ignore-body-lines.regex option accordingly. To > remove > > > this warning, set general.regex-style-search=True. More details: > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fjorisr > o%2F&data=05%7C02%7Ciulia.tanasescu%40nxp.com%7Ca4106b62fbbc421 > ba8b408dbfbf5aeb3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7 > C638380804836966878%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C% > 7C&sdata=XrUOmCiSuOT8hJl4%2BSDQDcFReZKgwEzLJOIls5n18J0%3D&reserv > ed=0 > > > overs.github.io%2Fgitlint%2Fconfiguration%2F%23regex-style- > > > > search&data=05%7C02%7Ciulia.tanasescu%40nxp.com%7C75f2033d3e9447 > d > > > be67d08dbfb3b5e2e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 > > > %7C638380004620835820%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4 > wLj > > > > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7 > > > > C%7C&sdata=GaHyvhsb4TOR1ksh3KcJ7f%2BLCN4JynFFoQdFs1cd2d8%3D&re > s > > > erved=0 > > > > 13: B3 Line contains hard tab characters (\t): " > > > 0000a0201030202010304280001020206000000000a02010302020103042 > > > 8" > > > > 14: B3 Line contains hard tab characters (\t): " > > > 0002020206000000000a02010302020103042800" > > > > [BlueZ,v4,3/6] org.bluez.MediaEndpoint: Add ChannelAllocation to > > > > SelectProperties > > > > > > > > WARNING: I3 - ignore-body-lines: gitlint will be switching from using > > > > Python regex 'match' (match beginning) to 'search' (match anywhere) > > > > semantics. Please review your ignore-body-lines.regex option > > > > accordingly. To remove this warning, set > > > > general.regex-style-search=True. More details: > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fjori% > 2F&data=05%7C02%7Ciulia.tanasescu%40nxp.com%7Ca4106b62fbbc421ba8 > b408dbfbf5aeb3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638 > 380804836966878%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi > LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&s > data=5dVv5DQNrxG9SDq5M3hdYZA0w4zglb08FgIHpo0yfag%3D&reserved=0 > > > > sroovers.github.io%2Fgitlint%2Fconfiguration%2F%23regex-style- > search&d > > > > > > > > ata=05%7C02%7Ciulia.tanasescu%40nxp.com%7C75f2033d3e9447dbe67d08 > > > dbfb3b > > > > > > > > 5e2e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6383800046 > > > 20835820%7 > > > > > > > > CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB > T > > > iI6Ik1 > > > > > > > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=GaHyvhsb4TOR1ksh3 > K > > > cJ7f%2BLCN > > > > 4JynFFoQdFs1cd2d8%3D&reserved=0 > > > > 1: T1 Title exceeds max length (81>80): "[BlueZ,v4,3/6] > > > org.bluez.MediaEndpoint: Add ChannelAllocation to SelectProperties" > > > > [BlueZ,v4,6/6] client/player: Use ChannelAllocation given on > > > > SelectProperties > > > > > > > > WARNING: I3 - ignore-body-lines: gitlint will be switching from using > Python > > > regex 'match' (match beginning) to 'search' (match anywhere) semantics. > > > Please review your ignore-body-lines.regex option accordingly. To > remove > > > this warning, set general.regex-style-search=True. More details: > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fjorisr > o%2F&data=05%7C02%7Ciulia.tanasescu%40nxp.com%7Ca4106b62fbbc421 > ba8b408dbfbf5aeb3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7 > C638380804836966878%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C% > 7C&sdata=XrUOmCiSuOT8hJl4%2BSDQDcFReZKgwEzLJOIls5n18J0%3D&reserv > ed=0 > > > overs.github.io%2Fgitlint%2Fconfiguration%2F%23regex-style- > > > > search&data=05%7C02%7Ciulia.tanasescu%40nxp.com%7C75f2033d3e9447 > d > > > be67d08dbfb3b5e2e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 > > > %7C638380004620835820%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4 > wLj > > > > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7 > > > > C%7C&sdata=GaHyvhsb4TOR1ksh3KcJ7f%2BLCN4JynFFoQdFs1cd2d8%3D&re > s > > > erved=0 > > > > 13: B3 Line contains hard tab characters (\t): " > > > 602020600000000100201030202010304280005030200000001020206000 > > > 0" > > > > 14: B3 Line contains hard tab characters (\t): " > > > 000010020103020201030428000503010000000202020600000000100201 > > > 0" > > > > 15: B3 Line contains hard tab characters (\t): " > > > 302020103042800050302000000" > > > > ############################## > > > > Test: ScanBuild - WARNING > > > > Desc: Run Scan Build > > > > Output: > > > > src/shared/bap.c:4766:23: warning: Access to field 'type' results in a > > > dereference of a null pointer (loaded from variable 'lpac') > > > > if (!match.rpac && (lpac->type != BT_BAP_BCAST_SOURCE)) > > > > ^~~~~~~~~~ > > > > 1 warning generated. > > > > In file included from tools/mesh-gatt/crypto.c:32: > > > > ./src/shared/util.h:228:9: warning: 1st function call argument is an > > > uninitialized value > > > > return be32_to_cpu(get_unaligned((const uint32_t *) ptr)); > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > ./src/shared/util.h:33:26: note: expanded from macro 'be32_to_cpu' > > > > #define be32_to_cpu(val) bswap_32(val) > > > > ^~~~~~~~~~~~~ > > > > /usr/include/byteswap.h:34:21: note: expanded from macro > 'bswap_32' > > > > #define bswap_32(x) __bswap_32 (x) > > > > ^~~~~~~~~~~~~~ > > > > In file included from tools/mesh-gatt/crypto.c:32: > > > > ./src/shared/util.h:238:9: warning: 1st function call argument is an > > > uninitialized value > > > > return be64_to_cpu(get_unaligned((const uint64_t *) ptr)); > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > ./src/shared/util.h:34:26: note: expanded from macro 'be64_to_cpu' > > > > #define be64_to_cpu(val) bswap_64(val) > > > > ^~~~~~~~~~~~~ > > > > /usr/include/byteswap.h:37:21: note: expanded from macro > 'bswap_64' > > > > #define bswap_64(x) __bswap_64 (x) > > > > ^~~~~~~~~~~~~~ > > > > 2 warnings generated. > > > > > > > > > > > > > > > > --- > > > > Regards, > > > > Linux Bluetooth > > > > > > > > > > > > > -- > > > Luiz Augusto von Dentz > > > > > > Regards, > > Iulia > > > > > -- > Luiz Augusto von Dentz Regards, Iulia
