Re: [PATCH BlueZ v1] client/player: Fix not prompting all parameter on endpoint.register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Luiz,


Am 07.12.23 um 19:47 schrieb Luiz Augusto von Dentz:
From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>

When Auto Accept is not enable not all parameters are requested.

enable*d*

---
  client/player.c | 10 +++-------
  1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/client/player.c b/client/player.c
index 4673d2efece8..4d49602c70d7 100644
--- a/client/player.c
+++ b/client/player.c
@@ -2813,17 +2813,13 @@ static void endpoint_auto_accept(const char *input, void *user_data)
  		return;
  	} else if (!strcasecmp(input, "n") || !strcasecmp(input, "no")) {
  		ep->auto_accept = false;
+		bt_shell_prompt_input(ep->path, "Max Transports (auto/value):",
+						endpoint_max_transports, ep);
+		return;
  	} else {
  		bt_shell_printf("Invalid input for Auto Accept\n");
  		return bt_shell_noninteractive_quit(EXIT_FAILURE);
  	}
-
-	if (ep->broadcast)
-		bt_shell_prompt_input(ep->path, "BIG (auto/value):",
-					endpoint_iso_group, ep);
-	else
-		bt_shell_prompt_input(ep->path, "CIG (auto/value):",
-					endpoint_iso_group, ep);
  }

Excuse my ignorance, but it’s not clear to me why *Max Transports* is now used instead of *BIG* or *CIG*, and what the code path is, that could not have led to one of the two prompts.

  static void endpoint_set_metadata(const char *input, void *user_data)


Kind regards,

Paul




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux