Re: [PATCH] Move HealthManager Interface to "/" path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Elvis Pfützenreuter <epx@xxxxxxxxxxx> [2011-02-15 17:45:05 -0200]:

> Hi Padovan,
> 
> On Feb 15, 2011, at 5:31 PM, Gustavo F. Padovan wrote:
> 
> > Yeah, this breaks the API, but health is still disabled by default and it
> > is not a good idea create a new path only for it. So moving it to "/"
> > ---
> > doc/health-api.txt    |    2 +-
> > health/hdp.c          |    4 ++--
> > test/test-health      |    2 +-
> > test/test-health-sink |    2 +-
> > 4 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/doc/health-api.txt b/doc/health-api.txt
> > index 3d0a717..9d5a54d 100644
> > --- a/doc/health-api.txt
> > +++ b/doc/health-api.txt
> > @@ -10,7 +10,7 @@ Health Device Profile hierarchy
> > 
> > Service		org.bluez
> > Interface	org.bluez.HealthManager
> > -Object path	/org/bluez/
> > +Object path	/
> > 
> > Methods:
> > 
> > diff --git a/health/hdp.c b/health/hdp.c
> > index d4a2a30..e58bd55 100644
> > --- a/health/hdp.c
> > +++ b/health/hdp.c
> > @@ -2171,7 +2171,7 @@ int hdp_manager_start(DBusConnection *conn)
> > {
> > 	DBG("Starting Health manager");
> > 
> > -	if (!g_dbus_register_interface(conn, MANAGER_PATH,
> > +	if (!g_dbus_register_interface(conn, "/",
> 
> I'd rather change macro value instead of removing it. Patch gets smaller. 
> (Or remove the macro definition along with its references.)

Yeah, I forgot to remove the macro definition.

-- 
Gustavo F. Padovan
http://profusion.mobi
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux