On 11/7/2023 12:16 AM, Luiz Augusto von Dentz wrote: > Hi, > > On Mon, Nov 6, 2023 at 1:19 AM Zijun Hu <quic_zijuhu@xxxxxxxxxxx> wrote: >> >> This patch series are to support SCO offload for QCA2066, ALL BTHOST >> needs to do is specifying both Input_Data_Path and Output_Data_Path >> as 0x01 for HCI_Enhanced_Setup_Synchronous_Connection, does NOT need >> to configure data path by HCI_Configure_Data_Path at all. > > This part it doesn't need to use HCI_Configure_Data_Path seems to be > non-standard, if so it needs to be handled by the driver, also it is > probably a good idea to explain how it works, what are the commands > used and the result traffic using btmon to collect the HCI trace. > My change does NOT touch current BT core driver logic at all. i just assign NULL to hdev->get_codec_config_data within QCA device driver. so it follows current kernel offload design. BTW, Core spec also does not specify standard procedures for SCO offload since it is vendor specific. >> Zijun Hu (2): >> Bluetooth: hci_conn: Check non NULL before calling >> hdev->get_codec_config_data() >> Bluetooth: qca: Support SCO offload for QCA2066 >> >> drivers/bluetooth/hci_qca.c | 19 +++++++++++++++++++ >> net/bluetooth/hci_conn.c | 2 +- >> 2 files changed, 20 insertions(+), 1 deletion(-) >> >> -- >> The Qualcomm Innovation Center >> > >
