Hi Luiz, > -----Original Message----- > From: Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> > Sent: Monday, October 16, 2023 8:01 PM > To: Iulia Tanasescu <iulia.tanasescu@xxxxxxx> > Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Claudia Cristina Draghicescu > <claudia.rosu@xxxxxxx>; Mihai-Octavian Urzica <mihai- > octavian.urzica@xxxxxxx>; Silviu Florian Barbulescu > <silviu.barbulescu@xxxxxxx>; Vlad Pruteanu <vlad.pruteanu@xxxxxxx>; > Andrei Istodorescu <andrei.istodorescu@xxxxxxx> > Subject: Re: [PATCH BlueZ 1/4] btio: Handle closed channel in server_cb > > Hi Iulia, > > On Mon, Oct 16, 2023 at 8:49 AM Iulia Tanasescu <iulia.tanasescu@xxxxxxx> > wrote: > > > > This handles G_IO_ERR and G_IO_HUP conditions in server_cb > > > > --- > > btio/btio.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/btio/btio.c b/btio/btio.c index d45b8240d..c63a6d1df > > 100644 > > --- a/btio/btio.c > > +++ b/btio/btio.c > > @@ -247,7 +247,8 @@ static gboolean server_cb(GIOChannel *io, > GIOCondition cond, > > GIOChannel *cli_io; > > > > /* If the user closed the server */ > > - if ((cond & G_IO_NVAL) || check_nval(io)) > > + if ((cond & (G_IO_NVAL | G_IO_ERR | G_IO_HUP)) || > > + check_nval(io)) > > I believe this was done on purpose to only check for NVAL, the other > conditions shall probably be notified back via callback so it can process the > error reported. > It seems that server_cb is supposed to accept an incoming connection on server io and pass the child io through the confirm or connect callbacks. But if the condition is G_IO_HUP for example, we shouldn't get to the point of calling accept. > > return FALSE; > > > > srv_sock = g_io_channel_unix_get_fd(io); > > -- > > 2.39.2 > > > > > -- > Luiz Augusto von Dentz Regards, Iulia
