Re: [PATCH BlueZ v1 1/1] gobex/gobex.c : Changed default obex timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Purendra-Singh,


Thank you for your patch.

Am 19.10.23 um 09:16 schrieb Purendra-Singh:
Description: File received status of some reference devices
is delayed, that causes timeout and file transfer status error.

Some formal issues:

1.  Please remove the redundant *Description* at the beginning.
2. Do you only have “one” name, or is the transcription(?) spelled without a hyphen/minus: Purendra Singh?
3.  Please be more specific in the commit messages summary/title. Maybe:

    > gobex: Increase default obex timeout from 10 ms to 500 ms

Most importantly, why did you pick 500 ms, and what reference device is it? (What chipset for example?)

---
  gobex/gobex.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gobex/gobex.c b/gobex/gobex.c
index e9b89cead..f0e1c2c83 100644
--- a/gobex/gobex.c
+++ b/gobex/gobex.c
@@ -22,7 +22,7 @@
  #define G_OBEX_MINIMUM_MTU	255
  #define G_OBEX_MAXIMUM_MTU	65535
-#define G_OBEX_DEFAULT_TIMEOUT 10
+#define G_OBEX_DEFAULT_TIMEOUT	500
  #define G_OBEX_ABORT_TIMEOUT	5
#define G_OBEX_OP_NONE 0xff


Kind regards,

Paul



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux