RE: [PATCH 2/2] shared/bap: Add support for Audio Locations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

> >  struct bt_bap_pac *bt_bap_add_pac(struct gatt_db *db, const char *name,
> >                                         uint8_t type, uint8_t id,
> >                                         struct bt_bap_pac_qos *qos,
> >                                         struct iovec *data,
> > -                                       struct iovec *metadata);
> > +                                       struct iovec *metadata,
> > +                                       uint32_t location);
> 
> If you change the API you will need to fix their users as well otherwise it
> won't build and CI will fail.

Agree. I also found later that location field is already part of qos structure. I would re-work to use the same instead of changing API and submit v2 patchset.
> 
> >  struct bt_bap_pac_ops {
> >         int (*select)(struct bt_bap_pac *lpac, struct bt_bap_pac
> > *rpac,
> > --
> > 2.34.1
> 
> 
> 
> --
> Luiz Augusto von Dentz

Thanks,
Kiran





[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux