Re: [PATCH 2/3] Fix not resetting indicators whenever the driver is initialized

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Feb 14, 2011 at 12:21 PM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> From: Luiz Augusto von Dentz <luiz.dentz-von@xxxxxxxxx>
>
> This may cause invalid values to be reported since the status of call can
> change during the time adaptor was off.
> ---
>  audio/telephony-maemo6.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/audio/telephony-maemo6.c b/audio/telephony-maemo6.c
> index 0c99c34..0ab1a77 100644
> --- a/audio/telephony-maemo6.c
> +++ b/audio/telephony-maemo6.c
> @@ -1981,6 +1981,15 @@ int telephony_init(void)
>        DBG("telephony-maemo6 registering %s interface on path %s",
>                        TELEPHONY_MAEMO_INTERFACE, TELEPHONY_MAEMO_PATH);
>
> +       /* Reset indicators */
> +       telephony_update_indicator(maemo_indicators, "battchg", 5);
> +       telephony_update_indicator(maemo_indicators, "signal", 0);
> +       telephony_update_indicator(maemo_indicators, "service", 0);
> +       telephony_update_indicator(maemo_indicators, "call", 0);
> +       telephony_update_indicator(maemo_indicators, "callsetup", 0);
> +       telephony_update_indicator(maemo_indicators, "callhelp", 0);
> +       telephony_update_indicator(maemo_indicators, "roam", 0);
> +
>        telephony_ready_ind(features, maemo_indicators, BTRH_NOT_SUPPORTED,
>                                                                chld_str);
>        if (send_method_call("org.freedesktop.Hal",
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Please ignore this, it is probably better to just reset the fields
directly and not call telephony_update_indicator.

-- 
Luiz Augusto von Dentz
Computer Engineer
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux