Hi Iulia,
On Wed, Sep 27, 2023 at 12:59 AM Iulia Tanasescu
<iulia.tanasescu@xxxxxxx> wrote:
>
> This makes it possible to bind a broadcast listener to a broadcaster
> address without asking for any BIS indexes to sync with.
Is the intend to use this logic for discovering broadcaster? I guess
we should make it clearer and perhaps have iso-tester also testing its
behavior.
> Signed-off-by: Iulia Tanasescu <iulia.tanasescu@xxxxxxx>
> ---
> net/bluetooth/hci_conn.c | 2 +-
> net/bluetooth/iso.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index e62a5f368a51..c4395d34da70 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -2138,7 +2138,7 @@ int hci_le_big_create_sync(struct hci_dev *hdev, struct hci_conn *hcon,
> } pdu;
> int err;
>
> - if (num_bis > sizeof(pdu.bis))
> + if (num_bis < 0x01 || num_bis > sizeof(pdu.bis))
> return -EINVAL;
>
> err = qos_set_big(hdev, qos);
> diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
> index 2132a16be93c..8ab7ea5ebedf 100644
> --- a/net/bluetooth/iso.c
> +++ b/net/bluetooth/iso.c
> @@ -790,8 +790,7 @@ static int iso_sock_bind_bc(struct socket *sock, struct sockaddr *addr,
> BT_DBG("sk %p bc_sid %u bc_num_bis %u", sk, sa->iso_bc->bc_sid,
> sa->iso_bc->bc_num_bis);
>
> - if (addr_len > sizeof(*sa) + sizeof(*sa->iso_bc) ||
> - sa->iso_bc->bc_num_bis < 0x01 || sa->iso_bc->bc_num_bis > 0x1f)
> + if (addr_len > sizeof(*sa) + sizeof(*sa->iso_bc))
> return -EINVAL;
>
> bacpy(&iso_pi(sk)->dst, &sa->iso_bc->bc_bdaddr);
> --
> 2.39.2
>
--
Luiz Augusto von Dentz
