Re: [PATCH BlueZ v2 1/2] shared/bap: detach io for source ASEs only after Stop Ready

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pauli,

On Sun, Sep 10, 2023 at 9:31 AM Pauli Virtanen <pav@xxxxxx> wrote:
>
> Hi Luiz,
>
> to, 2023-08-31 kello 14:04 -0700, Luiz Augusto von Dentz kirjoitti:
> > On Wed, Jul 5, 2023 at 11:18 AM <patchwork-bot+bluetooth@xxxxxxxxxx> wrote:
> > >
> > > Hello:
> > >
> > > This series was applied to bluetooth/bluez.git (master)
> > > by Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>:
> > >
> > > On Sun,  2 Jul 2023 21:43:04 +0300 you wrote:
> > > > The Client may terminate a CIS when sink is in QOS and source in
> > > > Disabling states (BAP v1.0.1 Sec 5.6.5).  It may also terminate it when
> > > > Receiver Stop Ready has completed successfully (BAP v1.0.1 Sec 5.6.5.1).
> > > >
> > > > It appears Samsung Galaxy Buds2 Pro (R510XXUOAWA5) ignores the Receiver
> > > > Stop Ready command if CIS is already disconnected, and then gets stuck
> > > > in disabling state. It works if CIS is disconnected after Receiver Stop
> > > > Ready.
> > > >
> > > > [...]
> > >
> > > Here is the summary with links:
> > >   - [BlueZ,v2,1/2] shared/bap: detach io for source ASEs only after Stop Ready
> > >     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7b10e72de6f4
> > >   - [BlueZ,v2,2/2] bap: wait for CIG to become configurable before recreating CIS
> > >     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8c3170190d6f
> > >
> > > You are awesome, thank you!
> > > --
> > > Deet-doot-dot, I am a bot.
> > > https://korg.docs.kernel.org/patchwork/pwbot.html
> >
> > Looks like this one introduces a problem when using the emulator:
> >
> > https://gist.github.com/Vudentz/5c7ef940fc97b054227559dcd47b99f7?permalink_comment_id=4677775#gistcomment-4677775
> >
> > If I try to release then acquire then it won't trigger recreate logic,
> > I suspect this is due to bap_io_disconnected being called ahead of
> > states changes.
>
> Sorry for the delay. Was this fixed by d06b912df5ab ("bap: Fix not
> always calling bap_io_close on disconnect")? If not, I'll try to
> reproduce.

Yeah, that should have been fixed already.

> --
> Pauli Virtanen



-- 
Luiz Augusto von Dentz




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux