From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> Passing UINT32_MAX as int may overfollow causing errors such as: bluetoothd[2688495]: src/main.c:parse_config_int() General.TemporaryTimeout = 60 is out of range (> -1) Fixes: https://github.com/bluez/bluez/issues/583#issuecomment-1713447461 --- src/main.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/main.c b/src/main.c index b5a6f8e5562f..cddf1396197b 100644 --- a/src/main.c +++ b/src/main.c @@ -440,9 +440,9 @@ static bool parse_config_string(GKeyFile *config, const char *group, static bool parse_config_int(GKeyFile *config, const char *group, const char *key, int *val, - int min, int max) + size_t min, size_t max) { - int tmp; + size_t tmp; char *str = NULL; char *endptr = NULL; @@ -456,12 +456,14 @@ static bool parse_config_int(GKeyFile *config, const char *group, } if (tmp < min) { - warn("%s.%s = %d is out of range (< %d)", group, key, tmp, min); + warn("%s.%s = %zu is out of range (< %zu)", group, key, tmp, + min); return false; } if (tmp > max) { - warn("%s.%s = %d is out of range (> %d)", group, key, tmp, max); + warn("%s.%s = %zu is out of range (> %zu)", group, key, tmp, + max); return false; } @@ -774,7 +776,7 @@ static bool parse_config_u32(GKeyFile *config, const char *group, { int tmp; - if (!parse_config_int(config, group, key, &tmp, 0, UINT32_MAX)) + if (!parse_config_int(config, group, key, &tmp, min, max)) return false; if (val) -- 2.41.0
