On 7/31/2023 4:48 PM, Paul Menzel wrote:
> Dear Zijun,
>
>
> Am 31.07.23 um 09:46 schrieb Zijun Hu:
>> Fix a logical error within parse_config_int().
>
> Thank you for spotting and fixing this. I guess this warning was printed on the terminal?
no any warnings by following Compilation steps of README.
>
> Although obvious, instead of duplicating the commit message summary in the body, it would be great, if you still wrote a more elaborate commit message. Maybe:
>
> Having a config file with the line below
>
> …
>
> causes the config file to be ignored, and the warning below:
>
> …
>
the error is very simple, so i don't write more to explain it.
>> ---
>> src/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/main.c b/src/main.c
>> index 150a5af4cca4..13501440b052 100644
>> --- a/src/main.c
>> +++ b/src/main.c
>> @@ -458,7 +458,7 @@ static bool parse_config_int(GKeyFile *config, const char *group,
>> return false;
>> }
>> - if (tmp < max) {
>> + if (tmp > max) {
>> warn("%s.%s = %d is out of range (> %d)", group, key, tmp, max);
>> return false;
>> }
>
> Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
>
>
> Kind regards,
>
> Paul
