Re: [PATCH BlueZ 1/2] adapter: Be able to use ConnectDevice for discovered devices

[Paul Menzel <pmenzel@xxxxxxxxxxxxx>]

[Cc: +Szymon]

Dear Simon,


Thank you for your patch. In the commit summary, an alternative to “Be 
able” could be “Allow”.

Am 31.07.23 um 06:12 schrieb Simon Mikuda:
> This can be useful when you want to specify trasport type for already

tra*n*sport

> paired device (e.g. use LE transport for dual mode device).

Could you please elaborate a little more? Maybe even give an example, 
how this can be tested?

> ---
>   src/adapter.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index 2679d4302..17f4a637d 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -3763,9 +3763,6 @@ static DBusMessage *connect_device(DBusConnection *conn,
>   	if (!bacmp(&addr, BDADDR_ANY))
>   		return btd_error_invalid_args(msg);
>   
> -	if (btd_adapter_find_device(adapter, &addr, addr_type))
> -		return btd_error_already_exists(msg);
> -
>   	device_connect(adapter, &addr, addr_type, msg);
>   	return NULL;
>   }