Re: [PATCH 6/7] Add ATT dump for read req/resp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Besides its opcode (which was already parsed), read response contains
only the attribute value octets.

To further parse it, I think we'd need to store the handle of the read
request, match it against a UUID table and maybe parse the read
response format, if any. Maybe too much work?

I must note I liked raw_dump() for this because it also prints out
chars, which make attribs. like device name have a nice dump.

On Wed, Feb 9, 2011 at 12:21 PM, Gustavo F. Padovan
<padovan@xxxxxxxxxxxxxx> wrote:
> Hi Andre,
>
> * Andre Dieb Martins <andre.dieb@xxxxxxxxxxx> [2011-02-09 11:01:49 -0300]:
>
>> ---
>> Âparser/att.c | Â 14 ++++++++++++++
>> Â1 files changed, 14 insertions(+), 0 deletions(-)
>>
>> diff --git a/parser/att.c b/parser/att.c
>> index b172f95..2a9da30 100644
>> --- a/parser/att.c
>> +++ b/parser/att.c
>> @@ -331,6 +331,14 @@ static void att_find_info_resp_dump(int level, struct frame *frm)
>> Â Â Â }
>> Â}
>>
>> +static void att_read_req_dump(int level, struct frame *frm)
>> +{
>> + Â Â uint16_t handle = btohs(htons(get_u16(frm)));
>> +
>> + Â Â p_indent(level, frm);
>> + Â Â printf("handle 0x%2.2x\n", handle);
>> +}
>> +
>> Âstatic void att_handle_notify_dump(int level, struct frame *frm)
>> Â{
>> Â Â Â uint16_t handle = btohs(htons(get_u16(frm)));
>> @@ -371,6 +379,12 @@ void att_dump(int level, struct frame *frm)
>> Â Â Â Â Â Â Â case ATT_OP_FIND_INFO_RESP:
>> Â Â Â Â Â Â Â Â Â Â Â att_find_info_resp_dump(level + 1, frm);
>> Â Â Â Â Â Â Â Â Â Â Â break;
>> + Â Â Â Â Â Â case ATT_OP_READ_REQ:
>> + Â Â Â Â Â Â Â Â Â Â att_read_req_dump(level + 1, frm);
>> + Â Â Â Â Â Â Â Â Â Â break;
>> + Â Â Â Â Â Â case ATT_OP_READ_RESP:
>> + Â Â Â Â Â Â Â Â Â Â raw_dump(level + 1, frm);
>
> raw_dump?
>
> --
> Gustavo F. Padovan
> http://profusion.mobi
>
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux