Gustavo, On Tue, Feb 8, 2011 at 11:46 PM, Gustavo F. Padovan <padovan@xxxxxxxxxxxxxx> wrote: > Hi Pavan, > > * pavan_savoy@xxxxxx <pavan_savoy@xxxxxx> [2011-02-07 06:12:17 -0600]: > >> From: Pavan Savoy <pavan_savoy@xxxxxx> >> >> Gustavo, >> >> Find below the patch version v9. >> Have taken care of Ville's comments. >> In addition fixed the issue seen when built as module, with >> repeated probe/remove of the platform driver. > Then remove this function... hci_core fails the register if the destruct function is not set. So I had kept the function..... I will shorten the goto label and re-submit. I hope that should be fine... >> +static int bt_ti_probe(struct platform_device *pdev) >> +{ >> + Â Â static struct ti_st *hst; >> + Â Â struct hci_dev *hdev; >> + Â Â int err; >> + >> + Â Â hst = kzalloc(sizeof(struct ti_st), GFP_KERNEL); >> + Â Â if (!hst) >> + Â Â Â Â Â Â return -ENOMEM; >> + >> + Â Â /* Expose "hciX" device to user space */ >> + Â Â hdev = hci_alloc_dev(); >> + Â Â if (!hdev) { >> + Â Â Â Â Â Â kfree(hst); >> + Â Â Â Â Â Â return -ENOMEM; >> + Â Â } >> + >> + Â Â BT_DBG("hdev %p", hdev); >> + >> + Â Â hst->hdev = hdev; >> + Â Â hdev->bus = HCI_UART; >> + Â Â hdev->driver_data = hst; >> + Â Â hdev->open = ti_st_open; >> + Â Â hdev->close = ti_st_close; >> + Â Â hdev->flush = NULL; >> + Â Â hdev->send = ti_st_send_frame; >> + Â Â hdev->destruct = ti_st_destruct; > > ...and also the line that sets it. > > -- > Gustavo F. Padovan > http://profusion.mobi > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html