Re: [PATCH BlueZ 0/2] shared/bass: Introduce Add Source opcode handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Iulia,

On Fri, Jun 23, 2023 at 12:51 AM Iulia Tanasescu
<iulia.tanasescu@xxxxxxx> wrote:
>
> This patch series adds the BASS control point handler
> for the Add Source operation.
>
> If instructed by a Client through the Add Source opcode,
> the BASS Server attempts to synchronize to a Broadcast
> Source, by opening a btio channel.
>
> The BT_IO_OPT_ISO_BC_ADDR btio option has been added,
> to allow binding a socket to a broadcast address.

Im having second thoughts on this, Im not sure if it is a good idea to
introduce BT_IO_OPT_ISO_BC_ADDR, there are already options to set the
address and address type, perhaps we should add what is missing e.g.
num of bis, etc. At least on iso-test the logic I used was that if a
destination is given for listen then it must be a broadcast address.

> The BASS adapter_probe callback has been implemented,
> in order to automatically configure BASS into the adapter
> database. The adapter bdaddr is also stored along with the
> BASS database configuration, and this address will be used
> as the source address when binding the btio channel.
>
> Iulia Tanasescu (2):
>   btio: Add option for binding iso broadcast address
>   shared/bass: Introduce Add Source opcode handler
>
>  Makefile.am           |   2 +-
>  btio/btio.c           |  56 +++++-
>  btio/btio.h           |   3 +-
>  profiles/audio/bass.c |  26 ++-
>  src/shared/bass.c     | 424 ++++++++++++++++++++++++++++++++++++++++--
>  src/shared/bass.h     |  14 +-
>  unit/test-bass.c      |   2 +-
>  7 files changed, 498 insertions(+), 29 deletions(-)
>
>
> base-commit: 37042ca9c6ddcdbbb0899b3d62238935cd53f443
> --
> 2.34.1
>


-- 
Luiz Augusto von Dentz




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux