Re: [PATCH BlueZ v2 1/2] Added initial code for handling VOCS

[Paul Menzel <pmenzel@xxxxxxxxxxxxx>]

Dear Nitin,


Thank you for your patch.

Am 07.06.23 um 14:13 schrieb Nitin Jadhav:

It’d be great if you used imperative mood in the commit message 
summary/title. Maybe:

Add initial VOCS code

> This adds implementation for VOCS service and characteristics

Please document the datasheet name and version, you used to write the code.

If you summarized the implementation, and also documented how you tested 
this, that’d be great.

> ---
> v2: Corrected prefixs and cosmetic changes (Luiz Augusto von Dentz)
> ---
>   lib/uuid.h       |   5 +
>   src/shared/vcp.c | 537 +++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 542 insertions(+)

[…]


Kind regards,

Paul