Hi Nitin, On Tue, Jun 6, 2023 at 5:09 AM NJNXP <nitin.jadhav@xxxxxxx> wrote: > > Hello Maintainers > > This patch series handles code implementation for mandatory features of > Volume Offset Control Service. > > Implementation of following features have been handled in this patch > series > - Volume Offset Control Service > - Volume Offset State Characteristic (Read, Notify) > - Audio Location Characteristic (Read) > - Volume Offset Control Point Characteristic (Write) > - Audio Output Description Characteristic (Read) > - Set Volume Offset > > All the code implementation has been tested using PTS testing the > verdict is PASS for all mandatory test cases. Great, though at this stage I think it would be even more important to have a unit tester for the bt_vcp instance, just as we do have for bt_bap and bt_bass in unit/test-bap.c and unit/test-bass.c respectively, this would help us making sure there are no memory issues and avoid introducing regressions going forward. > Thank you in advance for your review. > > Warm Regards > Nitin Jadhav > > NJNXP (2): > Added initial code for handling VOCS > Fixed the following issue observed during PTS testing for mandatory > test cases - Specified Upper and Lower Limit for Volume offset - > Corrected the number of handles for VOCS - VOCS is made as included > service of VCS because VOCS is secondary service and VSC is primary > service > > lib/uuid.h | 5 + > src/shared/vcp.c | 547 ++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 550 insertions(+), 2 deletions(-) > > -- > 2.34.1 > -- Luiz Augusto von Dentz
