Re: [bug report] Bluetooth: Add initial implementation of BIS connections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 24, 2023 at 09:38:34AM +0300, Dan Carpenter wrote:
> Hello Luiz Augusto von Dentz,
> 
> The patch eca0ae4aea66: "Bluetooth: Add initial implementation of BIS
> connections" from Mar 9, 2022, leads to the following Smatch static
> checker warning:
> 
> 	net/bluetooth/hci_conn.c:943 hci_le_remove_cig()
> 	warn: passing zero to 'ERR_PTR'
> 
> net/bluetooth/hci_conn.c
>     939 static int hci_le_remove_cig(struct hci_dev *hdev, u8 handle)
>                                                            ^^^^^^^^^^
> 
>     940 {
>     941         bt_dev_dbg(hdev, "handle 0x%2.2x", handle);
>     942 
> --> 943         return hci_cmd_sync_queue(hdev, remove_cig_sync, ERR_PTR(handle), NULL);
>                                                                          ^^^^^^
> handle is a u8.  It can hold error codes.

s/can/cannot/.

regards,
dan carpenter




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux