Hi Pavan, On Mon, Feb 07, 2011 at 04:38:52AM -0600, ext pavan_savoy@xxxxxx wrote: > From: Pavan Savoy <pavan_savoy@xxxxxx> > > Gustavo, > > As suggested, the modifications to TI ST driver to remove the bluetooth > references have been made and the changes have been merged to the > linux-next tree. > > Find below the patch for the btwilink driver, > I have taken care of your following comments, > 1. channel IDs and the offsets are now being taken from the > header file hci.h. > 2. removed the un-necessary BT_ERR. > 3. changed the order during return from st_register. > 4. continue to unregister even if 1st unregister fails. > > Please review and provide comments, Will do. Some comment > +/* Called from HCI core to initialize the device */ > +static int ti_st_open(struct hci_dev *hdev) > +{ > + unsigned long timeleft; > + struct ti_st *hst; > + int err, i; > + > + BT_DBG("%s %p", hdev->name, hdev); > + > + if (test_and_set_bit(HCI_RUNNING, &hdev->flags)) > + return -EBUSY; > + > + /* provide contexts for callbacks from ST */ > + hst = hdev->driver_data; > + > + for (i = 0; i < MAX_BT_CHNL_IDS; i++) { > + ti_st_proto[i].priv_data = hst; > + ti_st_proto[i].max_frame_size = HCI_MAX_FRAME_SIZE; > + > + err = st_register(&ti_st_proto[i]); > + if (!err) > + goto done_downloading_firmware; > + > + if (err != -EINPROGRESS) { > + clear_bit(HCI_RUNNING, &hdev->flags); > + BT_ERR("st_register failed %d", err); > + return err; > + } else { No need for else. Less indentation looks better to me at least. > + /* ST is busy with either protocol > + * registration or firmware download. > + */ > + /* Prepare wait-for-completion handler data structures. > + */ > + init_completion(&hst->wait_reg_completion); init_completion should be done before startin action which executes complete(). IOW this should be before st_register if I understood this correctly. Otherwise the started action might call complete before init_completion and wait_for_completion_timeout will just time even everything went fine. -- Ville -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html