Re: [PATCH 1/1] Bluetooth: Add support for creating multiple BISes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Iulia,


Thank you for your patch.

Am 17.05.23 um 09:27 schrieb Iulia Tanasescu:
It is required for some configurations to have multiple BISes as part
of the same BIG, which is now covered by iso-tester in the following test
case:

     ISO Broadcaster AC 13 - Success

Thank you for adding a test. Did you also test it on hardware? If so, please document your test setup.

A diffstat over hundred lines should have a more elaborate commit message. Could you please add a short note about the implementation?

Signed-off-by: Iulia Tanasescu <iulia.tanasescu@xxxxxxx>
---
  include/net/bluetooth/bluetooth.h |   2 +
  include/net/bluetooth/hci.h       |   7 ++
  include/net/bluetooth/hci_core.h  |  32 ++++++-
  include/net/bluetooth/iso.h       |  14 +++
  net/bluetooth/hci_conn.c          | 150 ++++++++++++++++++++++++------
  net/bluetooth/hci_core.c          |  18 ++++
  net/bluetooth/hci_event.c         |  98 +++++++++++++++----
  net/bluetooth/iso.c               |   4 +
  8 files changed, 277 insertions(+), 48 deletions(-)

diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
index 1b4230cd42a3..28a3b105fdf3 100644
--- a/include/net/bluetooth/bluetooth.h
+++ b/include/net/bluetooth/bluetooth.h
@@ -198,6 +198,8 @@ struct bt_iso_bcast_qos {
  	__u8  sync_cte_type;
  	__u8  mse;
  	__u16 timeout;
+	__u8  dummy[2]; /* Dummy octets for padding compatibility with old BlueZ */
+	__u8  num_bis;
  };
struct bt_iso_qos {
diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 07df96c47ef4..7567cbecf937 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -1,6 +1,7 @@
  /*
     BlueZ - Bluetooth protocol stack for Linux
     Copyright (C) 2000-2001 Qualcomm Incorporated
+   Copyright 2023 NXP

Above, Copyright is followed by (C). Should it be consistent?

[…]


Kind regards,

Paul



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux