Hi Paul, Thank you for reviewing this patch. > > static int nxp_check_boot_sign(struct btnxpuart_dev *nxpdev) > > { > > serdev_device_set_baudrate(nxpdev->serdev, > HCI_NXP_PRI_BAUDRATE); > > - serdev_device_set_flow_control(nxpdev->serdev, 0); > > + serdev_device_set_flow_control(nxpdev->serdev, 1); > > It was explicitly disabled before. Is it on by default? Flow control is disabled by default, and this is the first instance here, where it is enabled. > > Also, is there now a redundant line later in the flow enabling flow control, or > was it never enabled? Yes. Removed the redundant line as we are now enabling flow control in nxp_check_boot_sign(). > > Other place in the source code seem to use `true` or `false` instead of 1/0. Changed all instances of 0/1 to false/true in v2 patch. Thanks, Neeraj