On Wed, Mar 22, 2023 at 03:27:12PM +0800, hildawu@xxxxxxxxxxx wrote: > From: Hilda Wu <hildawu@xxxxxxxxxxx> > > Since limited tracking device per condition, this feature is to support > tracking multiple devices concurrently. > When a pattern monitor detects the device, this feature issues an address > monitor for tracking that device. Let pattern monitor can keep monitor > new devices. > This feature adds an address filter when receiving a LE monitor device > event which monitor handle is for a pattern, and the controller started > monitoring the device. And this feature also has cancelled the monitor > advertisement from address filters when receiving a LE monitor device > event when the controller stopped monitoring the device specified by an > address and monitor handle. > > Signed-off-by: Alex Lu <alex_lu@xxxxxxxxxxxxxx> > Signed-off-by: Hilda Wu <hildawu@xxxxxxxxxxx> > --- > Changes in v2: > - Fixed build bot warning, removed un-used parameter. > - Follow suggested, adjust for readability and idiomatic, modified > error case, etc. Thanks for addressing my review. If you do need to spin a v3, then you might want to consider using reverse xmas tree universally for local variable declarations in your new code. But that notwithstanding, from a code-style sanity check pov: Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
