Hi Paul, > -----Original Message----- > From: Tumkur Narayan, Chethan > Sent: Tuesday, March 21, 2023 8:59 AM > To: Paul Menzel <pmenzel@xxxxxxxxxxxxx> > Cc: Srivatsa, Ravishankar <ravishankar.srivatsa@xxxxxxxxx>; K, Kiran > <kiran.k@xxxxxxxxx>; linux-bluetooth@xxxxxxxxxxxxxxx > Subject: RE: [PATCH] Bluetooth: btintel: Fix: Add LE States quirk form Solar > onwards > > Thanks for the feedback, will send the updated patch. > > > -----Original Message----- > > From: Paul Menzel <pmenzel@xxxxxxxxxxxxx> > > Sent: Monday, March 20, 2023 6:40 PM > > To: Tumkur Narayan, Chethan <chethan.tumkur.narayan@xxxxxxxxx> > > Cc: Srivatsa, Ravishankar <ravishankar.srivatsa@xxxxxxxxx>; K, Kiran > > <kiran.k@xxxxxxxxx>; linux-bluetooth@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH] Bluetooth: btintel: Fix: Add LE States quirk form > > Solar onwards > > > > Dear Chethan, > > > > > > Thank you for your patch. There is a small typo in the summary/title: > > s/form/from/ > > > > Am 20.03.23 um 07:18 schrieb Chethan T N: > > > This patch shall enable the LE States quirks by default on all > > > > s/shall enable/enables/ ACK. > > > > > Intel controller from Solar products on wards. > > > > onwards ACK. > > > > Where is it documented, to enable that quirk for all? Based controller support the quick shall be added. Currently the quick was only applied for GarfieldPeak(GfP) however it is supported on all Intel controller. > > > > > Signed-off-by: Chethan T N <chethan.tumkur.narayan@xxxxxxxxx> > > > --- > > > drivers/bluetooth/btintel.c | 5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/bluetooth/btintel.c > > > b/drivers/bluetooth/btintel.c index af774688f1c0..7a6dc05553f1 > > > 100644 > > > --- a/drivers/bluetooth/btintel.c > > > +++ b/drivers/bluetooth/btintel.c > > > @@ -2684,9 +2684,8 @@ static int btintel_setup_combined(struct > > > hci_dev > > *hdev) > > > */ > > > set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, > > &hdev->quirks); > > > > > > - /* Valid LE States quirk for GfP */ > > > - if (INTEL_HW_VARIANT(ver_tlv.cnvi_bt) == 0x18) > > > - set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev- > > >quirks); > > > + /* Apply LE States quirk from solar onwards */ > > > + set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks); > > > > From the diff it is unclear, if Solar is the first “device”. So I’d > > be nice if you elaborated in the commit message. > > > > > > > > /* Setup MSFT Extension support */ > > > btintel_set_msft_opcode(hdev, > > > > > > Kind regards, > > > > Paul Thanks Chethan
