On Thu, Mar 16, 2023 at 4:58 AM Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote: > > Dear Steev, > > > Thank you for your patch. Some nits. > > Am 16.03.23 um 04:47 schrieb Steev Klimaszewski: > > Added regulators,GPIOs and changes required to power on/off wcn6855. > > Please add a space after the comma. > Good catch, sorry about that, will do in v7! > > Added support for firmware download for wcn6855. > > You might want to use imperative mood (Add …). > Bah, I'd seen others mention this, and still did it in mine :/ > How did you test this? What firmware files did you use? > > Maybe mention, that the assumption is, that it’s identical to WCN6750? > Are you wanting the firmware used in the commit message? I think I've seen similar in e.g. ath11k patches like: "Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1" something like that? The firmware itself is already in linux-firmware. I figured it wasn't imperative to the patch and it's in the cover letter but I can definitely throw it in the commit message! > > Signed-off-by: Steev Klimaszewski <steev@xxxxxxxx> > > Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx> > > Tested-by: Bjorn Andersson <andersson@xxxxxxxxxx> > > --- > > […] > > > Kind regards, > > Paul
