Hi Luiz, > -----Original Message----- > From: Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> > Sent: Thursday, March 16, 2023 10:52 AM > To: K, Kiran <kiran.k@xxxxxxxxx> > Cc: linux-bluetooth@xxxxxxxxxxxxxxx; Srivatsa, Ravishankar > <ravishankar.srivatsa@xxxxxxxxx>; Tumkur Narayan, Chethan > <chethan.tumkur.narayan@xxxxxxxxx> > Subject: Re: [PATCH v2 2/2] ACPI: utils: acpi_evaluate_dsm_typed - fix > redefinition error > > Hi Kiran, > > On Wed, Mar 15, 2023 at 5:32 PM Kiran K <kiran.k@xxxxxxxxx> wrote: > > > > acpi_evaluate_dsm_typed function needs to be gaurded with CONFIG_ACPI > > to avoid redefintion error when stub is also enabled. > > > > In file included from ../drivers/bluetooth/btintel.c:13: > > ../include/acpi/acpi_bus.h:57:1: error: redefinition of > 'acpi_evaluate_dsm_typed' > > 57 | acpi_evaluate_dsm_typed(acpi_handle handle, const guid_t *guid,.. > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > In file included from ../drivers/bluetooth/btintel.c:12: > > ../include/linux/acpi.h:967:34: note: previous definition of > > 'acpi_evaluate_dsm_typed' with type 'union acpi_object *(void *, const > > guid_t *, u64, u64, union acpi_object *, acpi_object_type)' > > {aka 'union acpi_object *(void *, const guid_t *, long long unsigned > > int, long long unsigned int, union acpi_object *, unsigned int)'} > > 967 | static inline union acpi_object > > *acpi_evaluate_dsm_typed(acpi_handle handle, > > > > Fixes: 1b94ad7ccc21 ("ACPI: utils: Add acpi_evaluate_dsm_typed() and > > acpi_check_dsm() stubs") > > This should probably be sent to the ACPI list/maintainer, but first make sure > there isn't already a fix which would mean we have to update bluetooth-next > to stop this kind of error. > Ok. It looks this issue is present in linux-pm tree. I have pushed the patch over there. I will let you know once its merged so that you can rebase bluetooth-next. Thanks Regards, Kiran