Hi Kiran, Thank you for the patch! Yet something to improve: [auto build test ERROR on bluetooth-next/master] [also build test ERROR on linus/master v6.3-rc2 next-20230310] [cannot apply to bluetooth/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kiran-K/Bluetooth-btintel-Add-support-to-reset-bluetooth-via-ACPI-DSM/20230313-230800 base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master patch link: https://lore.kernel.org/r/20230313151549.15791-1-kiran.k%40intel.com patch subject: [PATCH v1] Bluetooth: btintel: Add support to reset bluetooth via ACPI DSM config: arc-randconfig-r043-20230313 (https://download.01.org/0day-ci/archive/20230314/202303140634.L887SSqU-lkp@xxxxxxxxx/config) compiler: arc-elf-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/6a89221ddaa7b13fa1da2d345e61b2bf8efd5a87 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Kiran-K/Bluetooth-btintel-Add-support-to-reset-bluetooth-via-ACPI-DSM/20230313-230800 git checkout 6a89221ddaa7b13fa1da2d345e61b2bf8efd5a87 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/bluetooth/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303140634.L887SSqU-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/bluetooth/btintel.c: In function 'btintel_set_dsm_reset_method': >> drivers/bluetooth/btintel.c:2450:14: error: implicit declaration of function 'acpi_has_method'; did you mean 'acpi_has_watchdog'? [-Werror=implicit-function-declaration] 2450 | if (!acpi_has_method(handle, "_PRR")) { | ^~~~~~~~~~~~~~~ | acpi_has_watchdog cc1: some warnings being treated as errors vim +2450 drivers/bluetooth/btintel.c 2430 2431 static void btintel_set_dsm_reset_method(struct hci_dev *hdev, 2432 struct intel_version_tlv *ver_tlv) 2433 { 2434 struct btintel_data *data = hci_get_priv(hdev); 2435 acpi_handle handle = ACPI_HANDLE(GET_HCIDEV_DEV(hdev)); 2436 u8 reset_payload[4] = {0x01, 0x00, 0x01, 0x00}; 2437 union acpi_object *obj, argv4; 2438 enum { 2439 RESET_TYPE_WDISABLE2, 2440 RESET_TYPE_VSEC 2441 }; 2442 2443 handle = ACPI_HANDLE(GET_HCIDEV_DEV(hdev)); 2444 2445 if (!handle) { 2446 bt_dev_dbg(hdev, "No support for bluetooth device in ACPI firmware"); 2447 return; 2448 } 2449 > 2450 if (!acpi_has_method(handle, "_PRR")) { 2451 bt_dev_err(hdev, "No support for _PRR ACPI method"); 2452 return; 2453 } 2454 2455 switch (ver_tlv->cnvi_top & 0xfff) { 2456 case 0x910: /* GalePeak2 */ 2457 reset_payload[2] = RESET_TYPE_VSEC; 2458 break; 2459 default: 2460 /* WDISABLE2 is the default reset method */ 2461 reset_payload[2] = RESET_TYPE_WDISABLE2; 2462 2463 if (!acpi_check_dsm(handle, &btintel_guid_dsm, 0, 2464 BIT(DSM_SET_WDISABLE2_DELAY))) { 2465 bt_dev_err(hdev, "No dsm support to set reset delay"); 2466 return; 2467 } 2468 argv4.integer.type = ACPI_TYPE_INTEGER; 2469 /* delay required to toggle BT power */ 2470 argv4.integer.value = 160; 2471 obj = acpi_evaluate_dsm(handle, &btintel_guid_dsm, 0, 2472 DSM_SET_WDISABLE2_DELAY, &argv4); 2473 if (!obj) { 2474 bt_dev_err(hdev, "Failed to call dsm to set reset delay"); 2475 return; 2476 } 2477 ACPI_FREE(obj); 2478 } 2479 2480 bt_dev_info(hdev, "DSM reset method type: 0x%02x", reset_payload[2]); 2481 2482 if (!acpi_check_dsm(handle, &btintel_guid_dsm, 0, 2483 DSM_SET_RESET_METHOD)) { 2484 bt_dev_warn(hdev, "No support for dsm to set reset method"); 2485 return; 2486 } 2487 argv4.buffer.type = ACPI_TYPE_BUFFER; 2488 argv4.buffer.length = sizeof(reset_payload); 2489 argv4.buffer.pointer = reset_payload; 2490 2491 obj = acpi_evaluate_dsm(handle, &btintel_guid_dsm, 0, 2492 DSM_SET_RESET_METHOD, &argv4); 2493 if (!obj) { 2494 bt_dev_err(hdev, "Failed to call dsm to set reset method"); 2495 return; 2496 } 2497 ACPI_FREE(obj); 2498 data->acpi_reset_method = btintel_acpi_reset_method; 2499 } 2500 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
