On Mon, 13 Mar 2023, Neeraj sanjay kale wrote:
> >
> > Thanks, looks okay to me except this one I just noticed while preparing this
> > email:
> >
> > > +MODULE_DESCRIPTION("NXP Bluetooth Serial driver v1.0 ");
> >
> > I don't think version numbers belong to the module description.
> >
> I was asked to remove the MODULE_VERSION("v1.0") line in my v2 patch, hence kept it in the description.
> https://patchwork.kernel.org/project/bluetooth/patch/20230130180504.2029440-4-neeraj.sanjaykale@xxxxxxx/
>
> Please suggest me the right way to put the version string in this driver.
I think Leon meant you should just drop the version altogether (since this
is new code).
--
i.
> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> >
> >
> > --
> > i.
>
> Thank you again for reviewing this patch. :D
>
> -Neeraj
>
