Hi Greg, Thank you for your feedback. > > > + > > +static int init_baudrate = 115200; > > and neither will this, as you need to support multiple devices in the system, > your driver should never be only able to work with one device. > Please make these device-specific things, not the same for the whole driver. > I am using this init_baudrate as a module parameter static int init_baudrate = 115200; module_param(init_baudrate, int, 0444); MODULE_PARM_DESC(init_baudrate, "host baudrate after FW download: default=115200"); We need this parameter configurable since different chip module vendors using the same NXP chipset, configure these chips differently. For example, module vendor A distributes his modules based on NXP 88w8987 chips with a different configuration compared to module vendor B (based on NXP 88w8987), and the init_baudrate is one of the important distinctions between them. If we are able to keep this init_baudrate configurable, while compiling btnxpuart.ko as module, we will be able to support such baudrate variations. Please let me know your thoughts on this. Thanks, Neeraj
