On Tue, Nov 22 2022 at 15:04, Jacob Keller wrote: > On 11/22/2022 9:45 AM, Thomas Gleixner wrote: >> +int try_to_del_timer_sync(struct timer_list *timer) >> +{ >> + return __try_to_del_timer_sync(timer); >> +} >> EXPORT_SYMBOL(try_to_del_timer_sync); >> > > > Its a bit odd to me that some patches refactor and replace functions > with new variants all under timer_* namespace, but then we've left some > of them available without that. > > Any reasoning behind this? I guess "try_*" is pretty clear and unlikely > to get stolen by other code..? Kinda. I renamed del_timer*() because that's the ones which we want to substitute with timer_shutdown*() where possible and reasonable. A larger timer namespace cleanup is subject to a follow up series. Thanks, tglx