On Mon, Nov 21, 2022 at 11:42 AM Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
>
> On Mon, 2022-11-21 at 09:32 +0100, Íñigo Huguet wrote:
> >
> > > --- a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
> > > +++ b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
> > > @@ -1119,6 +1119,11 @@ int iwl_read_ppag_table(struct iwl_fw_runtime *fwrt, union iwl_ppag_table_cmd *c
> > > int i, j, num_sub_bands;
> > > s8 *gain;
> > >
> > > + /* many firmware images for JF lie about this */
> > > + if (CSR_HW_RFID_TYPE(fwrt->trans->hw_rf_id) ==
> > > + CSR_HW_RFID_TYPE(CSR_HW_RF_ID_TYPE_JF))
> > > + return -EOPNOTSUPP;
> > > +
> > > if (!fw_has_capa(&fwrt->fw->ucode_capa, IWL_UCODE_TLV_CAPA_SET_PPAG)) {
> > > IWL_DEBUG_RADIO(fwrt,
> > > "PPAG capability not supported by FW, command not sent.\n");
> > >
> > >
> > > johannes
> > >
> >
> > Sorry for the delay with this, I had some issues with the hardware.
> >
> > Using this workaround it doesn't show any errors and I can connect.
>
> OK.
>
> > However, using iwlwifi-QuZ-a0-jf-b0-74 from linux-firmware I get lots
> > of errors, both with this patch applied and without it. Maybe the
> > driver needs some changes?
> > I get stack traces, fw dumps and message `iwlwifi 0000:00:14.3: Failed
> > to send MAC context (action:1): -5`
>
> Probably some other error?
>
> > What would you recommend to do? It seems you didn't like this solution
> > very much (and, as I say, it doesn't work with fw 74)
>
>
> Well I think we still need this solution even if I didn't like it, and
Will you post the patch?
> the fw 74 seems to be a different issue - could you post more info about
> separately?
Sure, will do in a few hours, thanks!
>
> johannes
>
--
Íñigo Huguet
