Re: [PATCH BlueZ v7 6/6] adapter: Remove experimental flag for PowerState

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jonas,

On Sun, Nov 13, 2022 at 8:03 AM Jonas Dreßler <jonas@xxxxxxxxxxx> wrote:
>
> Hi everyone,
>
> Can we please apply this one, too? The property being experimental means distros
> need to downstream patch BlueZ for the feature to work, I'm not sure all packagers
> are aware of that.

Well experimental can be enabled by passing -E to bluetoothd, so it
can be enabled at runtime, that said we might switch it to stable on
the next release.

> FWIW, I can confirm the feature in gnome-shell works after removing the flag!
>
> Cheers,
> Jonas
>
> On 9/1/22 13:07, Bastien Nocera wrote:
> > Now that the feature has been tested, that the API is deemed adequate
> > and the reliability sufficient.
> > ---
> >   src/adapter.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/src/adapter.c b/src/adapter.c
> > index 8fb2acdc8..841096d7f 100644
> > --- a/src/adapter.c
> > +++ b/src/adapter.c
> > @@ -3864,8 +3864,7 @@ static const GDBusPropertyTable adapter_properties[] = {
> >       { "Alias", "s", property_get_alias, property_set_alias },
> >       { "Class", "u", property_get_class },
> >       { "Powered", "b", property_get_powered, property_set_powered },
> > -     { "PowerState", "s", property_get_power_state, NULL, NULL,
> > -                          G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> > +     { "PowerState", "s", property_get_power_state },
> >       { "Discoverable", "b", property_get_discoverable,
> >                                       property_set_discoverable },
> >       { "DiscoverableTimeout", "u", property_get_discoverable_timeout,
>


-- 
Luiz Augusto von Dentz




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux