RE: [BlueZ,1/2] hostname: Add '' around printed strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=693693

---Test result---

Test Summary:
CheckPatch                    FAIL      2.47 seconds
GitLint                       PASS      1.55 seconds
Prep - Setup ELL              PASS      27.77 seconds
Build - Prep                  PASS      0.72 seconds
Build - Configure             PASS      8.90 seconds
Build - Make                  PASS      897.96 seconds
Make Check                    PASS      11.55 seconds
Make Check w/Valgrind         PASS      297.53 seconds
Make Distcheck                PASS      245.83 seconds
Build w/ext ELL - Configure   PASS      8.99 seconds
Build w/ext ELL - Make        PASS      87.66 seconds
Incremental Build w/ patches  PASS      205.65 seconds
Scan Build                    PASS      519.08 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,2/2] hostname: Fallback to transient hostname
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#57: 
https://www.freedesktop.org/software/systemd/man/org.freedesktop.hostname1.html

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#80: FILE: plugins/hostname.c:48:
+static char *pretty_hostname    = NULL;

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#81: FILE: plugins/hostname.c:49:
+static char *static_hostname    = NULL;

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#82: FILE: plugins/hostname.c:50:
+static char *transient_hostname = NULL;

ERROR:INITIALISED_STATIC: do not initialise statics to 0
#83: FILE: plugins/hostname.c:51:
+static guint hostname_id = 0;

WARNING:LONG_LINE: line length of 84 exceeds 80 columns
#147: FILE: plugins/hostname.c:327:
+	hostname_io = g_io_channel_new_file("/proc/sys/kernel/hostname", "r", NULL);

WARNING:LONG_LINE: line length of 87 exceeds 80 columns
#149: FILE: plugins/hostname.c:329:
+		hostname_id = g_io_add_watch(hostname_io, G_IO_ERR, hostname_cb, NULL);

/github/workspace/src/13037643.patch total: 4 errors, 3 warnings, 100 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/13037643.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux