Re: [1/2] dt-bindings: net: broadcom-bluetooth: Add CYW4373A0 DT binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/1/22 23:44, Luiz Augusto von Dentz wrote:
Hi Marek,

Hi,

On Tue, Nov 1, 2022 at 3:38 PM Marek Vasut <marex@xxxxxxx> wrote:

On 10/31/22 23:07, bluez.test.bot@xxxxxxxxx wrote:
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690631

---Test result---

Test Summary:
CheckPatch                    PASS      2.99 seconds
GitLint                       PASS      1.48 seconds
SubjectPrefix                 FAIL      0.58 seconds

Should the DT bindings really have Bluetooth: prefix/tag too ?
git log on prior art indicates they shouldn't .

If it is meant for bluetooth-next then yes it shall contain it since
the CI does attempt to check its presence, in the other hand we could
perhaps use the prefix [bluetooth] to avoid having the CI run on
patches that are not meant for bluetooth-next but I don't think other
subsystem do require this so it sort of hard to enforce proper
prefixing.

Linux Documentation/devicetree/bindings seems to start with dt-bindings: prefix always, so maybe we should keep it that way ?

This binding document seems to follow the scheme now too:

next$ git log --oneline --follow Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml c8ce64900db47 dt-bindings: net: broadcom-bluetooth: Add conditional constraints
cba6164f7c5e3 dt-bindings: net: broadcom-bluetooth: Add CYW55572 DT binding
88b65887aa1b7 dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
0b4de2523f281 dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode
88ffadce9d4cc dt-bindings: bluetooth: broadcom: Fix clocks check
71793730ebfdb Bluetooth: btbcm: Add BCM4334 DT binding
7820ee1c4757d Bluetooth: btbcm: Rewrite bindings in YAML and add reset



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux