On Thu, Sep 08, 2022 at 01:19:17PM +0200, Krzysztof Kozlowski wrote: > On 07/09/2022 19:09, Sven Peter wrote: > > These chips are combined Wi-Fi/Bluetooth radios which expose a > > PCI subfunction for the Bluetooth part. > > They are found in Apple machines such as the x86 models with the T2 > > chip or the arm64 models with the M1 or M2 chips. > > > > Signed-off-by: Sven Peter <sven@xxxxxxxxxxxxx> > > --- > > changes from v1: > > - added apple,* pattern to brcm,board-type > > - s/PCI/PCIe/ > > - fixed 1st reg cell inside the example to not contain the bus number > > > > .../bindings/net/brcm,bcm4377-bluetooth.yaml | 78 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 79 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml b/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml > > new file mode 100644 > > index 000000000000..fb851f8e6bcb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml > > @@ -0,0 +1,78 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/brcm,bcm4377-bluetooth.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Broadcom BCM4377 family PCIe Bluetooth Chips > > + > > +allOf: > > + - $ref: bluetooth-controller.yaml# > > Put it before properties (so after description). > > > + > > +maintainers: > > + - Sven Peter <sven@xxxxxxxxxxxxx> > > + > > +description: > > + This binding describes Broadcom BCM4377 family PCIe-attached bluetooth chips > > + usually found in Apple machines. The Wi-Fi part of the chip is described in > > + bindings/net/wireless/brcm,bcm4329-fmac.yaml. > > + > > +properties: > > + compatible: > > + enum: > > + - pci14e4,5fa0 # BCM4377 > > + - pci14e4,5f69 # BCM4378 > > + - pci14e4,5f71 # BCM4387 > > + > > + reg: > > + description: PCI device identifier. > > maxItems: X And drop the description. > > > + > > + brcm,board-type: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: Board type of the Bluetooth chip. This is used to decouple > > + the overall system board from the Bluetooth module and used to construct > > + firmware and calibration data filenames. > > + On Apple platforms, this should be the Apple module-instance codename > > + prefixed by "apple,", e.g. "apple,atlantisb". > > + pattern: '^apple,.*' > > + > > + brcm,taurus-cal-blob: > > + $ref: /schemas/types.yaml#/definitions/uint8-array > > + description: A per-device calibration blob for the Bluetooth radio. This > > + should be filled in by the bootloader from platform configuration > > + data, if necessary, and will be uploaded to the device. > > + This blob is used if the chip stepping of the Bluetooth module does not > > + support beamforming. > > Isn't it: > s/beamforming/beam forming/ > ? > > > + > > + brcm,taurus-bf-cal-blob: > > + $ref: /schemas/types.yaml#/definitions/uint8-array > > + description: A per-device calibration blob for the Bluetooth radio. This > > + should be filled in by the bootloader from platform configuration > > + data, if necessary, and will be uploaded to the device. > > + This blob is used if the chip stepping of the Bluetooth module supports > > + beamforming. > > Same here. > > > + > > + local-bd-address: true > > + > > +required: > > + - compatible > > + - reg > > + - local-bd-address > > + - brcm,board-type > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + pcie { > > + #address-cells = <3>; > > + #size-cells = <2>; > > + > > + bluetooth@0,1 { > > The unit address seems to be different than reg. Right, this says dev 0, func 1. dtc can check this, but IIRC it would need 'device_type = "pci";' in the parent. So please add that, and verify you get a warning. Rob
