Hi Johan, On Mon, Dec 27, 2010 at 6:24 PM, Anderson Lizardo <anderson.lizardo@xxxxxxxxxxxxx> wrote: > On Mon, Dec 27, 2010 at 5:48 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: >> Beware of words like "also" and "and" in commit messages. Often they are >> a good indication that the patch shold be split into multiple ones. >> Though in this case I can't really make up my mind if it's fine since >> the changes are so strongly related. I'll leave it up to you to think >> about it and decide if you can cleanly split this into two patches or >> not. > > I can split into two patches without problem. I just sent a v3 of this patch, which I hope fix all issues. It is bigger than previous versions, but I assure it is solely to fix the leak of EIR data. The other benefits are just "side effects": * That if() clause which handles EIR name has been simplified, by removing free()/g_free() * I avoid passing ownership of memory allocated in src/event.c to src/adapter.c, which would potentially become memory leaks if not managed carefully. I hope these side effects are not of a big issue to be kept in a single patch. Regards, -- Anderson Lizardo OpenBossa Labs - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
