Hi Johan, On Mon, Dec 27, 2010 at 11:11 AM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > In general this seems fine, but to avoid future memory leaks in case you > go ahead and change the eir_data struct wouldn't it be better to have a > separate free_eir_data() function which does the g_slist_foreach, > g_slist_free and g_free? I followed your suggestion and created a free_eir_data(). I also did a simple code reordering that simplified the complete EIR name storage. See v2 of this patch. (2/4 should be ignored). Regards, -- Anderson Lizardo OpenBossa Labs - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html