On Mon, Dec 27, 2010 at 10:39 AM, Anderson Lizardo <anderson.lizardo@xxxxxxxxxxxxx> wrote: > Hi, > > On Mon, Dec 27, 2010 at 10:35 AM, <Michal.Labedzki@xxxxxxxxx> wrote: >> On Mon, Dec 27, 2010, Anderson Lizardo wrote: >>> IMHO, you should keep str2ba and drop the few occurrences of >>> strtoba(). Same applies to ba2str/batostr. >> >>> strtoba() allocates memory by itself, so if you use it instead, you >>> need to deallocate memory. str2ba(), on the other hand, uses a buffer >>> given as argument. >> >> These function are similar, but not the same. ba2str/str2ba reverse bdaddr, but >> batostr/strtoba not. I wrote relevant documentation comments, because names look >> similar, code look similar, but results are different. > > Ok, I confess the function names are confusing. One has to look at > their implementation to make sure which one to use... Just one more comment: on your commit description, it may appear that you are merging the functions, while in fact you are just factoring out common code. I suggest rewording the message so it makes clear you are factoring out code. Regards, -- Anderson Lizardo OpenBossa Labs - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
