On Mon, Dec 27, 2010 at 7:02 AM, Michal Labedzki
<michal.labedzki@xxxxxxxxx> wrote:
> + if (((*ptr < 'A' || *ptr > 'F') &&
> + (*ptr < 'a' || *ptr > 'f') &&
> + (*ptr < '0' || *ptr > '9')) ||
> + ( (ptr - str) == 2 && *ptr != ':')) {
> + bt_free(ba);
> + goto err_bdaddr;
> + }
The logic above seems wrong. Make sure you are not mixing || and &&.
> +
> + ++i;
> + ++ptr;
I think the usual coding style in bluez uses post-increment in these
cases (e.g. i++).
Regards,
--
Anderson Lizardo
OpenBossa Labs - INdT
Manaus - Brazil
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
