Hi Johan, > > And actually hci_init_req is not the only function where you would need > > to add hdev->req_last_cmd entries. There are hci_reset_req and some > > others. Without that, the rest of your patch makes hci_req_complete a > > non functional operation. > > Actually no, if req_last_cmd is 0 (which it is in all cases except > hci_init_req) then the comparison is not done: > > > + if (hdev->req_last_cmd && cmd != hdev->req_last_cmd) > > + return; > > I did this to keep the patch simple and to not have to change all the > single HCI command cases. I.e. only multi-HCI command requests need to > set this variable. not a huge fan of this, but if you put a comment on top then I could be convinced ;) Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html