Hi Claudio, On Thu, Dec 16, 2010, Claudio Takahasi wrote: > Currently, the purpose are service search functions and UUIDs utility functions. > glib-helper was originally created to implement some utility functions > to manage connections and sdp search abstractions. > Connection functions were moved/removed when btio was created. I have > two suggestions to try cleanup the code: > 1. keep only sdp functions that use GLib types and rename the file to > gsdp or other convenient name > 2. Or create a btd_device_search/cancel functions(moving them to > device.c) and try to remove glib-helper from the source tree, in the > worst case keep only functions to manipulate UUIDs > > The bt_discover_primary can be moved to gatt.c if we split the > discover cancel function. > bt_discover_services() can be removed, there isn't reference in code. > > Which approach do you prefer? Any other suggestion? Considering that around 90% of the file is SDP stuff right now I think option 1 sounds better. I.e. rename the file to something SDP related as well as create some more appropriate namespace for its public functions than bt_* Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
