On Tue, Dec 14, 2010 at 3:50 PM, Brian Gix <bgix@xxxxxxxxxxxxxx> wrote: > -- > Brian Gix > bgix@xxxxxxxxxxxxxx > Employee of Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum > > --- > attrib/att.c | 19 +++++++++++++++++++ > attrib/att.h | 2 ++ > 2 files changed, 21 insertions(+), 0 deletions(-) Usually, patches sent do Bluez, starte with short commit messages like: Add ... Fix ... Implement ... Note that we don't use "Added", "Fixed" etc. See the git log for reference. In this case, you should consider at least adding a short summary and your original summary as the "commit description", in the form: <short summary, e.g. "Implement Read Blob Request"> <empty line> <long description> Also as Vinicius mentioned, I think your e-mail signature will show up on the commit description if someone applies it with "git am". I suggest you send your patches with "git send-email". Another issue: looks your e-mail client replaced tabs with spaces (but it might just be Google messing up on my side). Regards, -- Anderson Lizardo OpenBossa Labs - INdT Manaus - Brazil -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
