Hi Lukasz, On Tue, Dec 14, 2010, Lukasz Pawlik wrote: > > I also wonder why we didn't use g_strsplit for this, it seems it would > > actually do the same, there is a little performance impact since we > > would have to iterate on the vector generated to call the callback > > while the current code do it in-place. > > Marcel, Johan any thoughts about this ? Should we reimplement this > code using glib functions ? It'd be nice to get some comments from Marcel since he is the original author of the textfile.c code. In general I'm not too happy about having to allocate a duplicate amount of memory for this (which is completely dependent on the file size), but I do agree that some fix is needed. I'd also like to make sure that we get a fix upstream before the next BlueZ release. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
